--- zzzz-none-000/linux-2.6.39.4/net/ipv6/mcast.c 2011-08-03 19:43:28.000000000 +0000 +++ puma6-atom-6490-729/linux-2.6.39.4/net/ipv6/mcast.c 2021-11-10 13:38:18.000000000 +0000 @@ -125,7 +125,7 @@ #define for_each_pmc_rcu(np, pmc) \ for (pmc = rcu_dereference(np->ipv6_mc_list); \ - pmc != NULL; \ + pmc; \ pmc = rcu_dereference(pmc->next)) int ipv6_sock_mc_join(struct sock *sk, int ifindex, const struct in6_addr *addr) @@ -151,7 +151,7 @@ mc_lst = sock_kmalloc(sk, sizeof(struct ipv6_mc_socklist), GFP_KERNEL); - if (mc_lst == NULL) + if (!mc_lst) return -ENOMEM; mc_lst->next = NULL; @@ -168,7 +168,7 @@ } else dev = dev_get_by_index_rcu(net, ifindex); - if (dev == NULL) { + if (!dev) { rcu_read_unlock(); sock_kfree_s(sk, mc_lst, sizeof(*mc_lst)); return -ENODEV; @@ -218,7 +218,7 @@ spin_lock(&ipv6_sk_mc_lock); for (lnk = &np->ipv6_mc_list; (mc_lst = rcu_dereference_protected(*lnk, - lockdep_is_held(&ipv6_sk_mc_lock))) !=NULL ; + lockdep_is_held(&ipv6_sk_mc_lock))); lnk = &mc_lst->next) { if ((ifindex == 0 || mc_lst->ifindex == ifindex) && ipv6_addr_equal(&mc_lst->addr, addr)) { @@ -229,7 +229,7 @@ rcu_read_lock(); dev = dev_get_by_index_rcu(net, mc_lst->ifindex); - if (dev != NULL) { + if (dev) { struct inet6_dev *idev = __in6_dev_get(dev); (void) ip6_mc_leave_src(sk, mc_lst, idev); @@ -288,7 +288,7 @@ spin_lock(&ipv6_sk_mc_lock); while ((mc_lst = rcu_dereference_protected(np->ipv6_mc_list, - lockdep_is_held(&ipv6_sk_mc_lock))) != NULL) { + lockdep_is_held(&ipv6_sk_mc_lock)))) { struct net_device *dev; np->ipv6_mc_list = mc_lst->next; @@ -827,7 +827,7 @@ /* we need to take a reference on idev */ idev = in6_dev_get(dev); - if (idev == NULL) + if (!idev) return -EINVAL; write_lock_bh(&idev->lock); @@ -854,7 +854,7 @@ mc = kzalloc(sizeof(struct ifmcaddr6), GFP_ATOMIC); - if (mc == NULL) { + if (!mc) { write_unlock_bh(&idev->lock); in6_dev_put(idev); return -ENOMEM; @@ -896,7 +896,7 @@ struct ifmcaddr6 *ma, **map; write_lock_bh(&idev->lock); - for (map = &idev->mc_list; (ma=*map) != NULL; map = &ma->next) { + for (map = &idev->mc_list; (ma = *map); map = &ma->next) { if (ipv6_addr_equal(&ma->mca_addr, addr)) { if (--ma->mca_users == 0) { *map = ma->next; @@ -1135,8 +1135,7 @@ return -EINVAL; idev = __in6_dev_get(skb->dev); - - if (idev == NULL) + if (!idev) return 0; mld = (struct mld_msg *)icmp6_hdr(skb); @@ -1259,7 +1258,7 @@ return -EINVAL; idev = __in6_dev_get(skb->dev); - if (idev == NULL) + if (!idev) return -ENODEV; /* @@ -1750,7 +1749,7 @@ skb = sock_alloc_send_skb(sk, LL_ALLOCATED_SPACE(dev) + full_len, 1, &err); - if (skb == NULL) { + if (!skb) { rcu_read_lock(); IP6_INC_STATS(net, __in6_dev_get(dev), IPSTATS_MIB_OUTDISCARDS); @@ -2301,7 +2300,7 @@ __ipv6_dev_mc_dec(idev, &in6addr_linklocal_allrouters); write_lock_bh(&idev->lock); - while ((i = idev->mc_list) != NULL) { + while ((i = idev->mc_list)) { idev->mc_list = i->next; write_unlock_bh(&idev->lock); @@ -2351,7 +2350,7 @@ im = im->next; while (!im) { - if (likely(state->idev != NULL)) + if (likely(state->idev)) read_unlock_bh(&state->idev->lock); state->dev = next_net_device_rcu(state->dev); @@ -2372,7 +2371,7 @@ { struct ifmcaddr6 *im = igmp6_mc_get_first(seq); if (im) - while (pos && (im = igmp6_mc_get_next(seq, im)) != NULL) + while (pos && (im = igmp6_mc_get_next(seq, im))) --pos; return pos ? NULL : im; } @@ -2397,7 +2396,7 @@ { struct igmp6_mc_iter_state *state = igmp6_mc_seq_private(seq); - if (likely(state->idev != NULL)) { + if (likely(state->idev)) { read_unlock_bh(&state->idev->lock); state->idev = NULL; } @@ -2462,14 +2461,14 @@ for_each_netdev_rcu(net, state->dev) { struct inet6_dev *idev; idev = __in6_dev_get(state->dev); - if (unlikely(idev == NULL)) + if (unlikely(!idev)) continue; read_lock_bh(&idev->lock); im = idev->mc_list; - if (likely(im != NULL)) { + if (likely(im)) { spin_lock_bh(&im->mca_lock); psf = im->mca_sources; - if (likely(psf != NULL)) { + if (likely(psf)) { state->im = im; state->idev = idev; break; @@ -2490,7 +2489,7 @@ spin_unlock_bh(&state->im->mca_lock); state->im = state->im->next; while (!state->im) { - if (likely(state->idev != NULL)) + if (likely(state->idev)) read_unlock_bh(&state->idev->lock); state->dev = next_net_device_rcu(state->dev); @@ -2517,7 +2516,7 @@ { struct ip6_sf_list *psf = igmp6_mcf_get_first(seq); if (psf) - while (pos && (psf = igmp6_mcf_get_next(seq, psf)) != NULL) + while (pos && (psf = igmp6_mcf_get_next(seq, psf))) --pos; return pos ? NULL : psf; } @@ -2544,11 +2543,11 @@ __releases(RCU) { struct igmp6_mcf_iter_state *state = igmp6_mcf_seq_private(seq); - if (likely(state->im != NULL)) { + if (likely(state->im)) { spin_unlock_bh(&state->im->mca_lock); state->im = NULL; } - if (likely(state->idev != NULL)) { + if (likely(state->idev)) { read_unlock_bh(&state->idev->lock); state->idev = NULL; }