--- zzzz-none-000/linux-2.4.17/drivers/pcmcia/sa1100_xp860.c 2001-10-11 16:43:29.000000000 +0000 +++ sangam-fb-322/linux-2.4.17/drivers/pcmcia/sa1100_xp860.c 2004-11-24 13:23:45.000000000 +0000 @@ -23,6 +23,14 @@ /* MAX1600 to standby mode: */ PA_DWR &= ~(GPIO_GPIO0 | GPIO_GPIO1 | GPIO_GPIO2 | GPIO_GPIO3); + +#error Consider the following comment + /* + * 1- Please move GPDR initialisation where it is interrupt or preemption + * safe (like from xp860_map_io). + * 2- The GPCR line is bogus i.e. it will simply have absolutely no effect. + * Please see its definition in the SA1110 manual. + */ GPDR |= (NCR_A0VPP | NCR_A1VPP); GPCR &= ~(NCR_A0VPP | NCR_A1VPP);