--- zzzz-none-000/linux-3.10.107/arch/powerpc/platforms/powermac/udbg_adb.c 2017-06-27 09:49:32.000000000 +0000 +++ scorpion-7490-727/linux-3.10.107/arch/powerpc/platforms/powermac/udbg_adb.c 2021-02-04 17:41:59.000000000 +0000 @@ -191,7 +191,7 @@ * of type "adb". If not, we return a failure, but we keep the * bext output set for now */ - for (np = NULL; (np = of_find_node_by_name(np, "keyboard")) != NULL;) { + for_each_node_by_name(np, "keyboard") { struct device_node *parent = of_get_parent(np); int found = (parent && strcmp(parent->type, "adb") == 0); of_node_put(parent);